Summary

Make alert colors consistent.

Review Request #10547 — Created May 1, 2019 and submitted June 12, 2019, 4:36 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We have a bunch of things which can be vaguely grouped as
"alerts"--error conditions, update notifications, banners, and issues.
These all used very similar (almost indistinguishable) but not quite
identical color codes. This change makes them all consistent under a
single definition.

Testing Done

Looked at the changed UI elements and verified that they all appeared
correctly.

Commits

Summary	ID
Make alert colors consistent. We have a bunch of things which can be vaguely grouped as "alerts"--error conditions, update notifications, banners, and issues. These all used very similar (almost indistinguishable) but not quite identical color codes. This change makes them all consistent under a single definition. Testing Done: Looked at the changed UI elements and verified that they all appeared correctly.	b7f5beae9d896e0a96b23cef391d2e7cbe4d165b

Summary

Make alert colors consistent.

We have a bunch of things which can be vaguely grouped as "alerts"--error conditions, update notifications, banners, and issues. These all used very similar (almost indistinguishable) but not quite identical color codes. This change makes them all consistent under a single definition. Testing Done: Looked at the changed UI elements and verified that they all appeared correctly.

b7f5beae9d896e0a96b23cef391d2e7cbe4d165b

Files

Issues

Description	From	Last Updated
Can you show screenshots of the issue banner and update notification? I'm mostly interested in seeing how these have changed.	chipx86	May 16, 2019, 10:28 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you show screenshots of the issue banner and update notification? I'm mostly interested in seeing how these have changed.

david May 16, 2019, 10:28 p.m.

I'm going to be surprised if you can tell the difference. I can't.

Added Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (9c52cc0)