Summary

Add legacy aliases for the recently-removed SSH key properties.

Review Request #10538 — Created April 17, 2019 and submitted May 17, 2019, 2:17 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We have some unit tests outside of Review Board that make use of the old
key1, key2, key1_b64, and key2_b64 SSH keys in SSHTestCase.
These broke with the migration of these keys to the newer SSH key
support for unit tests, and that code needs to work with older and newer
versions of Review Board.

This change adds legacy properties that forward on to the new keys,
preserving backwards-compatibility.

Testing Done

Unit tests pass in Review Board and our in-house tests.

Commits

Summary	ID
Add legacy aliases for the recently-removed SSH key properties. We have some unit tests outside of Review Board that make use of the old `key1`, `key2`, `key1_b64`, and `key2_b64` SSH keys in `SSHTestCase`. These broke with the migration of these keys to the newer SSH key support for unit tests, and that code needs to work with older and newer versions of Review Board. This change adds legacy properties that forward on to the new keys, preserving backwards-compatibility.	22d149d6d514e519307270a7614ba69f382b11f1

Summary

Add legacy aliases for the recently-removed SSH key properties.

We have some unit tests outside of Review Board that make use of the old `key1`, `key2`, `key1_b64`, and `key2_b64` SSH keys in `SSHTestCase`. These broke with the migration of these keys to the newer SSH key support for unit tests, and that code needs to work with older and newer versions of Review Board. This change adds legacy properties that forward on to the new keys, preserving backwards-compatibility.

22d149d6d514e519307270a7614ba69f382b11f1

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (11a3727)