Summary

Replace remaining use of ReviewRequest.get_last_activity

Review Request #10532 — Created April 14, 2019 and submitted April 24, 2019, 4:31 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

There were a few places left not using
ReviewRequest.get_last_activity_info and therefore triggering
deprecation warnings. This replaces all remaining uses of
ReviewRequest.get_last_activity with
ReviewRequest.get_last_activity_info.

Testing Done

Ran unit tests.

Commits

Summary	ID	Author
Replace remaining use of ReviewRequest.get_last_activity There were a few places left not using `ReviewRequest.get_last_activity_info` and therefore triggering deprecation warnings. This replaces all remaining uses of `ReviewRequest.get_last_activity` with `ReviewRequest.get_last_activity_info`. Testing done: Ran unit tests.	be85b218fe73e30fa7d35c56d4e53090e28486b9	Barret Rennie

Issues

Description	From	Last Updated
F841 local variable 'updated_object' is assigned to but never used	reviewbot	April 14, 2019, 7:23 p.m.
F841 local variable 'updated_object' is assigned to but never used	reviewbot	April 14, 2019, 7:23 p.m.
F841 local variable 'updated_object' is assigned to but never used	reviewbot	April 14, 2019, 7:23 p.m.
F841 local variable 'updated_object' is assigned to but never used	reviewbot	April 14, 2019, 7:24 p.m.
F841 local variable 'last_activity_time' is assigned to but never used	reviewbot	April 14, 2019, 7:25 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/ui/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'updated_object' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'updated_object' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'updated_object' is assigned to but never used
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'updated_object' is assigned to but never used
```

Commits:

	Summary	ID	Author
	Replace remaining use of ReviewRequest.get_last_activity There were a few places left not using `ReviewRequest.get_last_activity_info` and therefore triggering deprecation warnings. This replaces all remaining uses of `ReviewRequest.get_last_activity` with `ReviewRequest.get_last_activity_info`. Testing done: Ran unit tests.	7d3d36e482beb6bbe610b81d4b036c90bd0ad4c8	Barret Rennie
	Replace remaining use of ReviewRequest.get_last_activity There were a few places left not using `ReviewRequest.get_last_activity_info` and therefore triggering deprecation warnings. This replaces all remaining uses of `ReviewRequest.get_last_activity` with `ReviewRequest.get_last_activity_info`. Testing done: Ran unit tests.	0705806b9285d2d4037cb1e9eddcc4bdeba38fce	Barret Rennie

Diff:

Revision 2 (+20 -18)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/ui/base.py
	reviewboard/webapi/resources/base_comment.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F841 local variable 'last_activity_time' is assigned to but never used
```

Commits:

	Summary	ID	Author
	Replace remaining use of ReviewRequest.get_last_activity There were a few places left not using `ReviewRequest.get_last_activity_info` and therefore triggering deprecation warnings. This replaces all remaining uses of `ReviewRequest.get_last_activity` with `ReviewRequest.get_last_activity_info`. Testing done: Ran unit tests.	0705806b9285d2d4037cb1e9eddcc4bdeba38fce	Barret Rennie
	Replace remaining use of ReviewRequest.get_last_activity There were a few places left not using `ReviewRequest.get_last_activity_info` and therefore triggering deprecation warnings. This replaces all remaining uses of `ReviewRequest.get_last_activity` with `ReviewRequest.get_last_activity_info`. Testing done: Ran unit tests.	be85b218fe73e30fa7d35c56d4e53090e28486b9	Barret Rennie

Diff:

Revision 3 (+20 -18)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/ui/base.py
	reviewboard/webapi/resources/base_comment.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (b89471f)