• 
      

    Register the Local Site url template tag on Django 1.11.

    Review Request #10525 — Created April 10, 2019 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    On Django 1.6, we replace the {% url %} template tag with our own by
    adding it to the built-in list of tags through the add_to_builtins()
    method. On newer versions, we have a much cleaner way of doing this by
    listing the module as a built-in template tag library in settings.

    This change makes use of the new setting, and avoids calling
    add_to_builtins() on newer releases where it doesn't exist.

    Unit tests pass on Django 1.6 and 1.11.

    Manually tested the site on both to ensure that {% url %} was
    working with Local Sites and non-Local Sites.

    Summary ID
    Register the Local Site url template tag on Django 1.11.
    On Django 1.6, we replace the `{% url %}` template tag with our own by adding it to the built-in list of tags through the `add_to_builtins()` method. On newer versions, we have a much cleaner way of doing this by listing the module as a built-in template tag library in settings. This change makes use of the new setting, and avoids calling `add_to_builtins()` on newer releases where it doesn't exist.
    3e7a09126a9159773b1fb327ff1a21a1e624af84
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (30cbcdd)