Summary

ensure utf-8 encoding when processing commit message

Review Request #10520 — Created April 8, 2019 and discarded Aug. 18, 2020, 11:37 a.m.

Owner

Repository

RBTools

Branch

Bugs

Depends On

Groups

People

Description

The rbt post command fails to post review with error

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 57: ordinal not in range(128)

When commit message has a unicode char, for example:
TlsOverhead.callOpNull true thrpt 25 12865.357 ± 135.963 ops/s

Testing Done

Afer localy patching the rbtool I was able to post the review into our RB server.

Issues

Description	From	Last Updated
What SCM are you using? This data should already be unicode.	david	April 23, 2019, 2:22 p.m.
E501 line too long (91 > 79 characters)	reviewbot	April 8, 2019, 2:02 p.m.

flake8 failed.

JSHint passed.

rbtools/clients/__init__.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (91 > 79 characters)
```

Fix it!

An issue was opened. Show all issues

What SCM are you using? This data should already be unicode.

rbtools/clients/__init__.py (Diff revision 1)