• 
      

    Fix saving the user/group access list for repositories.

    Review Request #10518 — Created April 4, 2019 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    We had a regression in repository saving where the user and group access
    lists weren't being saved. While users would be validated against the
    user list, any changes made would be thrown out. The solution was to add
    a save_m2m() call (which is needed when choosing not to immediately
    save the model to the database through commit=False). Unit tests were
    added to catch regressions here in the future.

    Unit tests pass.

    Verified manually that I could alter the users and groups lists without
    any problems.

    Summary ID
    Fix saving the user/group access list for repositories.
    We had a regression in repository saving where the user and group access lists weren't being saved. While users would be validated against the user list, any changes made would be thrown out. The solution was to add a `save_m2m()` call (which is needed when choosing not to immediately save the model to the database through `commit=False`). Unit tests were added to catch regressions here in the future.
    ecd49ad11ec230a92b6270108e17e5506c1844b0
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (7c73393)