Summary

Avoid double-patching querysets in LocalSiteAwareModelFormMixin.

Review Request #10482 — Created March 31, 2019 and submitted April 10, 2019, 8:39 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The mixin for ensuring Local Site restrictions for forms was

double-patching querysets when limiting to a Local Site. The first patch

would happen at form construction time, and the second would happen at

form cleaning time (though this one was temporary). This caused queries

like SELECT ... WHERE local_site_id=1 AND local_site_id=1.
This change fixes that to only patch during form cleaning if it hasn't

already patched at form construction.
It also updates the field accesses to work with newer versions of

Django, and splits a unit test for these restrictions into two to avoid

an ordering difference on the newer versions.

Testing Done

Unit tests pass on Django 1.6 and 1.11 (with other in-progress changes).

Commits

Summary	ID
Avoid double-patching querysets in LocalSiteAwareModelFormMixin. The mixin for ensuring Local Site restrictions for forms was double-patching querysets when limiting to a Local Site. The first patch would happen at form construction time, and the second would happen at form cleaning time (though this one was temporary). This caused queries like `SELECT ... WHERE local_site_id=1 AND local_site_id=1`. This change fixes that to only patch during form cleaning if it hasn't already patched at form construction. It also updates the field accesses to work with newer versions of Django, and splits a unit test for these restrictions into two to avoid an ordering difference on the newer versions.	7997dc6f77652f914ff250af4a42f231916341c4

Summary

Avoid double-patching querysets in LocalSiteAwareModelFormMixin.

The mixin for ensuring Local Site restrictions for forms was double-patching querysets when limiting to a Local Site. The first patch would happen at form construction time, and the second would happen at form cleaning time (though this one was temporary). This caused queries like `SELECT ... WHERE local_site_id=1 AND local_site_id=1`. This change fixes that to only patch during form cleaning if it hasn't already patched at form construction. It also updates the field accesses to work with newer versions of Django, and splits a unit test for these restrictions into two to avoid an ordering difference on the newer versions.

7997dc6f77652f914ff250af4a42f231916341c4

Issues

Description	From	Last Updated
F811 redefinition of unused 'test_post_all_repositories_not_same_local_site' from line 132	reviewbot	March 31, 2019, 8:19 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_webhook.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F811 redefinition of unused 'test_post_all_repositories_not_same_local_site' from line 132
```

Change Summary:

Fixed a duplicate test name and re-ran all tests.

Commits:

	Summary	ID
	Avoid double-patching querysets in LocalSiteAwareModelFormMixin. The mixin for ensuring Local Site restrictions for forms was double-patching querysets when limiting to a Local Site. The first patch would happen at form construction time, and the second would happen at form cleaning time (though this one was temporary). This caused queries like `SELECT ... WHERE local_site_id=1 AND local_site_id=1`. This change fixes that to only patch during form cleaning if it hasn't already patched at form construction. It also updates the field accesses to work with newer versions of Django, and splits a unit test for these restrictions into two to avoid an ordering difference on the newer versions.	8de47eb231978efa20ee2d9386829d1381f02c88
	Avoid double-patching querysets in LocalSiteAwareModelFormMixin. The mixin for ensuring Local Site restrictions for forms was double-patching querysets when limiting to a Local Site. The first patch would happen at form construction time, and the second would happen at form cleaning time (though this one was temporary). This caused queries like `SELECT ... WHERE local_site_id=1 AND local_site_id=1`. This change fixes that to only patch during form cleaning if it hasn't already patched at form construction. It also updates the field accesses to work with newer versions of Django, and splits a unit test for these restrictions into two to avoid an ordering difference on the newer versions.	7997dc6f77652f914ff250af4a42f231916341c4

Diff:

Revision 2 (+158 -52)

Show changes

	reviewboard/site/mixins.py
	reviewboard/webapi/tests/test_webhook.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (4b79377)