• 
      

    Update management commands for Django 1.11 compatibility and modern standards.

    Review Request #10476 — Created March 29, 2019 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    This updates all of the management commands to be compatible with both
    Django 1.6 and 1.11, using the compatibility layer in Djblets. The major
    differences between these releases is that there's only a BaseCommand
    class, rather than a NoArgsCommand subclass (which wasn't even
    important in Django 1.6), and that option parsing uses argparse
    instead of optparse (which the Djblets compatibility class bridges for
    us).

    Many of the commands have also been updated to meet modern coding
    standards. This includes doc strings, localization, and small style
    tweaks. Not all of the commands received this treatment. Some are
    scheduled to be removed, and others (like fill-database) requires a
    larger amount of work than was intended for this change.

    Tested each management command individually on Django 1.6 and 1.11.

    Summary ID
    Update management commands for Django 1.11 compatibility and modern standards.
    This updates all of the management commands to be compatible with both Django 1.6 and 1.11, using the compatibility layer in Djblets. The major differences between these releases is that there's only a `BaseCommand` class, rather than a `NoArgsCommand` subclass (which wasn't even important in Django 1.6), and that option parsing uses `argparse` instead of `optparse` (which the Djblets compatibility class bridges for us). Many of the commands have also been updated to meet modern coding standards. This includes doc strings, localization, and small style tweaks. Not all of the commands received this treatment. Some are scheduled to be removed, and others (like `fill-database`) requires a larger amount of work than was intended for this change.
    259338d143fdc6201c9b19adf9d7dda16327d022
    Description From Last Updated

    E225 missing whitespace around operator

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (92836e7)