Fix some improper string types in the LDAP backend.

 






 

 


  Review Request #10474
  —
  Created March 28, 2019 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The LDAP backend was passing byte strings in some places where Unicode

strings were needed, and assuming Unicode strings where byte strings

might be. This wasn't a problem on Python 2, but was on Python 3.


This updates the known places in the LDAP code where this was impacting

unit tests, passing and forcing the right string types in these cases.

 








  


 
 

  
Unit tests pass on Python 2/3.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Fix some improper string types in the LDAP backend.
     
The LDAP backend was passing byte strings in some places where Unicode
strings were needed, and assuming Unicode strings where byte strings
might be. This wasn't a problem on Python 2, but was on Python 3.

This updates the known places in the LDAP code where this was impacting
unit tests, passing and forcing the right string types in these cases.

    

   
  		
  26abd26fa824d3f0bae4ba4bf60b22f85fd051a8
  Christian Hammond
 


 
  
 
 
  
   
    

     Fix some improper string types in the LDAP backend.
     
The LDAP backend was passing byte strings in some places where Unicode
strings were needed, and assuming Unicode strings where byte strings
might be. This wasn't a problem on Python 2, but was on Python 3.

This updates the known places in the LDAP code where this was impacting
unit tests, passing and forcing the right string types in these cases.

    

   
  		
  9fdae810c912ae39bf690e39cdeebaa896357146
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/tests/test_ldap_auth_backend.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...