Summary

Fix some improper string types in the LDAP backend.

Review Request #10474 — Created March 28, 2019 and submitted April 10, 2019, 4:59 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates the known places in the LDAP code where this was impacting
unit tests, passing and forcing the right string types in these cases.

Testing Done

Unit tests pass on Python 2/3.

Commits

Summary	ID
Fix some improper string types in the LDAP backend. The LDAP backend was passing byte strings in some places where Unicode strings were needed, and assuming Unicode strings where byte strings might be. This wasn't a problem on Python 2, but was on Python 3. This updates the known places in the LDAP code where this was impacting unit tests, passing and forcing the right string types in these cases.	9fdae810c912ae39bf690e39cdeebaa896357146

Summary

Fix some improper string types in the LDAP backend.

The LDAP backend was passing byte strings in some places where Unicode strings were needed, and assuming Unicode strings where byte strings might be. This wasn't a problem on Python 2, but was on Python 3. This updates the known places in the LDAP code where this was impacting unit tests, passing and forcing the right string types in these cases.

9fdae810c912ae39bf690e39cdeebaa896357146

flake8 passed.

JSHint passed.

Change Summary:

Added the missing unit test update.

Commits:

	Summary	ID
	Fix some improper string types in the LDAP backend. The LDAP backend was passing byte strings in some places where Unicode strings were needed, and assuming Unicode strings where byte strings might be. This wasn't a problem on Python 2, but was on Python 3. This updates the known places in the LDAP code where this was impacting unit tests, passing and forcing the right string types in these cases.	26abd26fa824d3f0bae4ba4bf60b22f85fd051a8
	Fix some improper string types in the LDAP backend. The LDAP backend was passing byte strings in some places where Unicode strings were needed, and assuming Unicode strings where byte strings might be. This wasn't a problem on Python 2, but was on Python 3. This updates the known places in the LDAP code where this was impacting unit tests, passing and forcing the right string types in these cases.	9fdae810c912ae39bf690e39cdeebaa896357146

Diff:

Revision 2 (+12 -12)

Show changes

	reviewboard/accounts/backends/ldap.py
	reviewboard/accounts/tests/test_ldap_auth_backend.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (43ea8a9)