Summary

Split the API test suite into per-module tests.

Review Request #10462 — Created March 21, 2019 and submitted May 17, 2019, 2:19 a.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The API tests were getting a bit unwieldy, and we wanted to make room
for future growth. To help prepare for this, this change splits up the
single tests.py file into a series of files under
rbtools/api/tests/.

These tests do not currently live up to our naming, docstring, and
organizational standards. Those will be addressed in another change.

Testing Done

Unit tests pass.

Commits

Summary	ID
Split the API test suite into per-module tests. The API tests were getting a bit unwieldy, and we wanted to make room for future growth. To help prepare for this, this change splits up the single `tests.py` file into a series of files under `rbtools/api/tests/`. These tests do not currently live up to our naming, docstring, and organizational standards. Those will be addressed in another change.	bc1e1913e859e91707f227d40cbb5814f003fa49

Issues

Description	From	Last Updated
W391 blank line at end of file	reviewbot	March 21, 2019, 3:07 a.m.
W391 blank line at end of file	reviewbot	March 21, 2019, 3:07 a.m.
W391 blank line at end of file	reviewbot	March 21, 2019, 3:07 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/tests/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
rbtools/api/tests/test_factory.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
rbtools/api/tests/test_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Change Summary:

Removed blank lines at the end of some files.

Commits:

	Summary	ID
	Split the API test suite into per-module tests. The API tests were getting a bit unwieldy, and we wanted to make room for future growth. To help prepare for this, this change splits up the single `tests.py` file into a series of files under `rbtools/api/tests/`. These tests do not currently live up to our naming, docstring, and organizational standards. Those will be addressed in another change.	cf2448f1310f496f5ee68cb3e78fcb9a89dbcc82
	Split the API test suite into per-module tests. The API tests were getting a bit unwieldy, and we wanted to make room for future growth. To help prepare for this, this change splits up the single `tests.py` file into a series of files under `rbtools/api/tests/`. These tests do not currently live up to our naming, docstring, and organizational standards. Those will be addressed in another change.	bc1e1913e859e91707f227d40cbb5814f003fa49

Diff:

Revision 2 (+1398 -2106)

Show changes

	rbtools/api/tests.py
	rbtools/api/tests/__init__.py
	rbtools/api/tests/base.py
	rbtools/api/tests/test_capabilities.py
	rbtools/api/tests/test_factory.py
	rbtools/api/tests/test_request.py
	rbtools/api/tests/test_resource.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (691280d)

rbtools/api/tests/base.py (Diff revision 1)