Summary

Fix regressions posting changes for review with custom diff files.

Review Request #10460 — Created March 20, 2019 and submitted March 21, 2019, 4:36 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Some of the DVCS work broke posting changes using --diff-filename
for review. There was a typo in an argument to a method, and a
variable that didn't have a default value. This is a simple change
that fixes both.

Testing Done

Posted several changes on my dev server with this.

Commits

Summary	ID
Fix regressions posting changes for review. Some of the DVCS work broke posting changes for review. There was a typo in an argument to a method, and a variable that didn't have a default value. This is a simple change that fixes both.	06b11936c8dc7b27e37a3a785f5870570d5b67ed

flake8 passed.

JSHint passed.

Testing Done:: ~
Posted this change, and the past several changes, with this.
~
Posted several changes on my dev server with this.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (6272a27)

~		Posted this change, and the past several changes, with this.
	~	Posted several changes on my dev server with this.