• 
      

    Fix a unit test regression for WebHooks.

    Review Request #10457 — Created March 20, 2019 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    A while back, JSON serialization for the API was changed to always
    return ordered keys. This affected WebHooks, but the unit test was never
    fixed up to account for this.

    This change fixes up the expected WebHook payload, ordering the keys.
    When I say "ordering," it's based on the json module's method of
    ordering, which orders them before converting to strings, which is why
    "null" (None) is first.

    Unit tests pass.

    Summary ID
    Fix a unit test regression for WebHooks.
    A while back, JSON serialization for the API was changed to always return ordered keys. This affected WebHooks, but the unit test was never fixed up to account for this. This change fixes up the expected WebHook payload, ordering the keys. When I say "ordering," it's based on the `json` module's method of ordering, which orders them before converting to strings, which is why `"null"` (`None`) is first.
    b0d46f733d1d91251652592e8dfba005e9d80426
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (2b975ba)