Summary

Fix visibility of the upload diff UI.

Review Request #10436 — Created Feb. 27, 2019 and submitted March 8, 2019, 1:40 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The newer version of jQuery we're using on release-4.0.x has a behavior
difference in .show() where it won't override a default style of
display: none. This meant that the way we were showing/hiding the
various pages of the upload diff UI (used both for the "Update Diff" and
"New Review Request" flows) wasn't working.

This change makes it so we don't have any default visibility and instead
handle all the showing/hiding via JavaScript.

Testing Done

Loaded the New Review Request and Update Diff UIs and saw the correct
view.

Commits

Summary	ID
Fix visibility of the upload diff UI. The newer version of jQuery we're using on release-4.0.x has a behavior difference in `.show()` where it won't override a default style of `display: none`. This meant that the way we were showing/hiding the various pages of the upload diff UI (used both for the "Update Diff" and "New Review Request" flows) wasn't working. This change makes it so we don't have any default visibility and instead handle all the showing/hiding via JavaScript. Testing Done: Loaded the New Review Request and Update Diff UIs and saw the correct view.	160bceeada4bf0bae5885f736acbd7f617ed377d

Summary

Fix visibility of the upload diff UI.

The newer version of jQuery we're using on release-4.0.x has a behavior difference in `.show()` where it won't override a default style of `display: none`. This meant that the way we were showing/hiding the various pages of the upload diff UI (used both for the "Update Diff" and "New Review Request" flows) wasn't working. This change makes it so we don't have any default visibility and instead handle all the showing/hiding via JavaScript. Testing Done: Loaded the New Review Request and Update Diff UIs and saw the correct view.

160bceeada4bf0bae5885f736acbd7f617ed377d

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (2857ceb)