Summary

Upgrade to LESS 3.9.0

Review Request #10427 — Created Feb. 22, 2019 and submitted March 7, 2019, 10:58 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-1.0.x

Bugs

Depends On

Commit

d92fae8...

Reviewers

Groups

djblets

People

Description

This change upgrades us to the latest LESS version for the Djblets
1.0/Review Board 3.0 series. This matches a change which was already
done for 2.0/4.0.

Testing Done


Verified that stylesheets still compiled correctly.
Built the djblets package.

Issues

Description	From	Last Updated
Can you test package builds for both Djblets and Review Board? I've hit issues in the past that only manfiested …	chipx86	Feb. 28, 2019, 12:19 p.m.
Just to verify, was the Review Board package also built?	chipx86	March 1, 2019, 1:11 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you test package builds for both Djblets and Review Board? I've hit issues in the past that only manfiested during packaging, and I think I hit something on release-4.0.x when we upgraded (or maybe that was JS-related).

Testing Done:

~		Verified that stylesheets still compiled correctly.
	~	Verified that stylesheets still compiled correctly.
	+	Built the djblets package.

Commit:

747ad41ac2028cf0d87308fefff82aa4749d6905

d92fae87749b530b11b93365b114ac640ea247d5

Diff:

Revision 2 (+4 -2)

Show changes

	djblets/dependencies.py
	djblets/settings.py
	djblets/pipeline/compilers/less-imports.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Just to verify, was the Review Board package also built?

david March 1, 2019, 1:11 p.m.

Yes. There's a trivial change that needs to happen on the RB side (adding --js to the LESS args in setup.py) for that, but I figured I'd just land that at the same time.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.0.x (be0fea1)