• 
      

    Fix issues reloading the Issue Summary Table.

    Review Request #10426 — Created Feb. 21, 2019 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    The recent work on the Issue Summary Table caused a regression when
    attempting to reload the table after an automated review. The JavaScript
    view was setting the element as a child of #issue-summary, but when
    reloading, we'd replace the view's element with the entire HTML of the
    table, including the #issue-summary container. This caused a strange
    nesting issue and broke element lookups, along with the rest of the
    page.

    We now once again use #issue-summary as the view's element, with the
    selectors inside adjusted accordingly.

    Unit tests pass.

    Tested loading, interacting with, and reloading the table.

    Summary ID
    Fix issues reloading the Issue Summary Table.
    The recent work on the Issue Summary Table caused a regression when attempting to reload the table after an automated review. The JavaScript view was setting the element as a child of `#issue-summary`, but when reloading, we'd replace the view's element with the entire HTML of the table, _including_ the `#issue-summary` container. This caused a strange nesting issue and broke element lookups, along with the rest of the page. We now once again use `#issue-summary` as the view's element, with the selectors inside adjusted accordingly.
    a157fbb370e4158d03b17eaf61ef70d8e9c0b5ee
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (1f531dc)