• 
      

    Modernize the structure, naming, and rules for config forms CSS styles.

    Review Request #10423 — Created Feb. 20, 2019 and submitted

    Information

    Djblets
    release-1.0.x

    Reviewers

    The config forms CSS styles were hobbled together from a bunch of styles
    found in Review Board, RBCommons, and Splat, and in the process of
    moving these into Djblets, we ended up with some unwanted rules and some
    very specific styling and naming that didn't make sense to keep in
    Djblets. We also have some new styles coming for config forms that was
    hard to put in without a bit of a cleanup.

    This change moves the styles to our new CSS naming standards, helping
    create a more logical, organized, documented set of components we can
    build upon, and in the process helps us move away from a bunch of
    unwanted styles. We still have those styles, and the old names, for
    backwards-compatibility purposes, but going forward we have a stronger
    foundation to build upon, and a clear path to deprecation.

    Some of these styles might come back in some other form later, but the
    intent is to go back to something closer to a bare minimum. That said,
    none of this is set in stone yet, and there are many form-related styles
    that deserve its own cleanup (and are not considered "stable" at this
    point).

    Tested that all the backwards-compatibility parts work with the My Account
    page in Review Board and both the My Account and Team Admin pages in
    RBCommons.

    Made use of some of the new styles in some upcoming work.

    Summary ID
    Modernize the structure, naming, and rules for config forms CSS styles.
    The config forms CSS styles were hobbled together from a bunch of styles found in Review Board, RBCommons, and Splat, and in the process of moving these into Djblets, we ended up with some unwanted rules and some very specific styling and naming that didn't make sense to keep in Djblets. We also have some new styles coming for config forms that was hard to put in without a bit of a cleanup. This change moves the styles to our new CSS naming standards, helping create a more logical, organized, documented set of components we can build upon, and in the process helps us move away from a bunch of unwanted styles. We still have those styles, and the old names, for backwards-compatibility purposes, but going forward we have a stronger foundation to build upon, and a clear path to deprecation. Some of these styles might come back in some other form later, but the intent is to go back to something closer to a bare minimum. That said, none of this is set in stone yet, and there are many form-related styles that deserve its own cleanup (and are not considered "stable" at this point). To help with review, this change does not reorder the styles into logical sections, instead retaining the rough order of the original styles. The next change in the series builds upon this to group related styles into logical sections in the stylesheet.
    7bf431ff7dd80031b1f133d21de628a8867fe619
    Reorder the config forms styles.
    This wraps up the new config form organization change by moving the styles into a logical order, grouping component-related styles together and ensuring alphabetical order. It doesn't make any changes to the styles themselves.
    dfba0e78c019d75b5afa85102f432fd1d7161550
    Description From Last Updated

    Alphabetize?

    daviddavid

    Alphabetize?

    daviddavid

    Alphabetize?

    daviddavid
    david
    1. 
        
    2. Show all issues

      Alphabetize?

    3. djblets/static/djblets/css/config-forms.less (Diff revision 1)
       
       
       
       
      Show all issues

      Alphabetize?

    4. Show all issues

      Alphabetize?

    5. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.0.x (f63e426)