flake8
passed.
JSHint
passed.
Rename the admin widget classes.
Review Request #10414 — Created Feb. 18, 2019 and submitted
This change renames the admin widget classes to conform to our new
standard for CSS, and reorganizes a lot of the CSS to match. There's
only one small visual change, switching the background of the "Add Small
Widgets" button to be white to match the appearance of the "Add Large
Widgets" button.
Verified the appearance of the admin dashboard.
| Summary | ID |
|---|---|
| 50b306ebf1f18ccf1cf0ac35271f27e504cf6088 |
| Description | From | Last Updated |
|---|---|---|
|
Typo in the description: "teh" |
 chipx86
|
|
|
Can you document these and the other elements, the way I did with the new CSS I've added? I want … |
chipx86
|
|
|
If this is meant to be a fully-namespaced modifier, it should be &--is-large. |
chipx86
|
|
|
Modifiers should have a - prefix, so -is-collapsable |
chipx86
|
|
|
Same here. |
chipx86
|
|
|
&.-has-actions |
chipx86
|
|
|
-is-hidden |
chipx86
|
|
|
-is-hidden Can you fix up the quoting style of affected lines while you're in here? |
chipx86
|
|
|
Missing second backtick on the end of -is-small. |
chipx86
|
|
|
These should be defined in a Modifiers section, like: /** * ... * * Modifiers: * -is-collapsable: * description... * … |
chipx86
|
|
|
Modifiers are standalone classes. They should be -is-large, rather than rb-c-admin-widget--is-large. Original BEM uses the latter form, but we're not … |
chipx86
|
- Description:
-
This change renames the admin widget classes to conform to our new
standard for CSS, and reorganizes a lot of the CSS to match. There's only one small visual change, switching the background of the "Add Small ~ Widgets" button to be white to match the appearance of teh "Add Large ~ Widgets" button to be white to match the appearance of the "Add Large Widgets" button. - Commits:
-
Summary ID 8c4c222fe133d334fe0c2167222adf9756212b14 7f0a0270f75ff878283f73453f5d1a7d8ef8c39f
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Commits:
-
Summary ID 7f0a0270f75ff878283f73453f5d1a7d8ef8c39f b5fe6c96d6521f5108e4ae00ec23bf6068b39ab3
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
These should be defined in a
Modifierssection, like:/** * ... * * Modifiers: * -is-collapsable: * description... * * -is-hidden: * description... */ -
Modifiers are standalone classes. They should be
-is-large, rather thanrb-c-admin-widget--is-large. Original BEM uses the latter form, but we're not (many other projects also don't, as it's not often necessary to be that strict).This applies to other modifier classes and the docs as well.