Update the Issue Summary Table for new shared styles and improvements.
Review Request #10386 — Created Jan. 17, 2019 and submitted
This updates the Issue Summary Table to derive most of its style and
structure from the commonrb-review-request-field-tabular
base style,
changing the structure a bit and removing much of the custom styling it
needed. The design of the table is much more simplified, reducing how
many custom CSS classes we inject into the table.In the process, it applies a number of fixes to the table:
1) The issue text now stays aligned alongside the issue icon.
2) The issue icon is horizontally centered in relation to the avatar
icons when in mobile mode.
3) The tabs no longer wrap in a broken way on mobile mode, and the "All
Issues" is now shortened to "All".
4) The JavaScript code is much more optimized, reducing the work needed
while loading the table or applying filters.
5) The design of the table no longer assumes there's only a single
instance on the page, making it more self-contained.
6) The counter for issues being verified now properly updates.Unit tests have also been added to test issues in verifying states.
Unit tests passed.
Tested all operations and updates extensively in mobile and desktop modes.
Summary | ID |
---|---|
d254657ddde36b530ffcd88074fd1dfa3f94ca69 |
Description | From | Last Updated |
---|---|---|
Col: 53 Expected '===' and instead saw '=='. |
reviewbot |
- Change Summary:
-
Changed a
==
to===
- Commits:
-
Summary ID badee5dcc52fe5b295d19b0508e5ccebd49f3bd6 4a7cb244bfcfe4c0f6a8dfbe0db48ff0627fbf7d - Diff:
-
Revision 2 (+1066 -1036)
- Added Files:
Checks run (2 succeeded)
- Change Summary:
-
- Fine-tuned the alignment of text on rows, so that text is always aligned with each other.
- Moved to using
.rb-c-tabs
. - Fixed styling when avatars are disabled.
- Commits:
-
Summary ID 4a7cb244bfcfe4c0f6a8dfbe0db48ff0627fbf7d d254657ddde36b530ffcd88074fd1dfa3f94ca69 - Diff:
-
Revision 3 (+1140 -1054)