flake8
passed.
JSHint
passed.
Unified Review Banner: Review Menu
Review Request #10360 — Created Dec. 13, 2018 and discarded
The Unified Review Banner: Review Menu is a follow-up to the Unified
Review Banner: Base Shell patch #10196.The Review Menu will be registered on the unified banner and appear
when there is no current draft review. The menu will be displayed on
hover and will allow the user to either create a new, blank review,
or to mark it with "Ship It!". When there is a draft review, a discard
button will be registered on the unified banner to allow the user to
discard the current draft review.
Added new JS tests to test functionality added. All JS tests pass.
Note: there are some tests that will still be added to this patch in
ReviewablePageViewTeststo test the changes introduced with the
Unified Review Banner: Review Menu in that file in this patch.
- Diff:
-
Revision 2 (+515 -137)
- Added Files:
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Summary:
-
[WIP] Unified Review Banner: Review MenuUnified Review Banner: Review Menu
- Description:
-
~ Note: the changes from the icons are covered by 10347, they also show up here because I needed to base this branch off of the Unified Review Banner Base Shell changes because there is more overlap there.
~ The Unified Review Banner: Review Menu is a follow-up to the Unified
+ Review Banner: Base Shell patch #10196. + + The Review Menu will be registered on the unified banner and appear
+ when there is no current draft review. The menu will be displayed on + hover and will allow the user to either create a new, blank review, + or to mark it with "Ship It!". When there is a draft review, a discard + button will be registered on the unified banner to allow the user to + discard the current draft review. - Testing Done:
-
+ Added new JS tests to test functionality added. All JS tests pass.
+ + Note: there are some tests that will still be added to this patch in
+ ReviewablePageViewTeststo test the changes introduced with the+ Unified Review Banner: Review Menu in that file in this patch. - Branch:
-
release-4.0.xmaster
- Commit:
-
bb358a45236bbe093b19cebc2d1ab55f9ab351203086804c0b49d31975dc88a8a43432a66dbb0693
- Diff:
-
Revision 3 (+417 -71)
- Added Files:
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
