• 
      

    Increase the FileDiff filename limit to 1024 characters.

    Review Request #1034 — Created Sept. 12, 2009 and submitted

    Information

    Review Board
    release-1.0.x
    751

    Reviewers

    Increase the FileDiff filename limit to 1024 characters.
    
    The filename limit in FileDiffs were previously 256 characters, which was
    fine for Subversion and other systems generally, but it was possible to hit
    this boundary and get some confusing errors. This is far more common with
    ClearCase, where filenames can get quite large.
    
    The maximum filename size in ClearCase is 1024 characters, which seems like
    a pretty decent size. This change bumps up the max size to 1024 characters
    and adds a unit test to make sure this does in fact work.
    Ran the unit test against MySQL and it worked fine. Before this database change, it failed.