Review Composer: Comment UI
Review Request #10324 — Created Nov. 17, 2018 and updated — Latest diff uploaded
I have added some visual changes to emulate the style of
the Comment UI in the design document version of the Review
Composer. These are mostly CSS based. I used a similar solution
for the Ship it checkbox on the "Open an Issue" checkbox.
I also moved the "Edit" icon to the right of the screen through
CSS to emulate the look of the design document.Added some code for the dropdown menu. Not finished.
I ran the JS unit tests and there weren't any errors.
The inclusion of the new code for the dropdown menu in textEditorView.es6.js caused some tests to fail.
Diff Revision 3
This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.
orig
1
2
3
4
5
6
7
reviewboard/static/rb/css/pages/reviews.less |
---|
reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js |
---|
reviewboard/static/rb/js/views/reviewComposerView.es6.js |
---|