Convert more JS code to ES6.

Review Request #10323 — Created Nov. 16, 2018 and submitted

david
Review Board
release-4.0.x
4db95d7...
reviewboard

This covers the various code in the diffviewer directory.

Ran js-tests.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
chipx86
  1. 
      
  2. Can we put this in alphabetical order?

    We're also missing docs for these, if you feel like fleshing those out.

  3. reviewboard/static/rb/js/diffviewer/models/paginationModel.es6.js (Diff revision 1)
     
     
     
     
     
     
     
     
     

    Alphabetical order.

    If you're up for docs, it'd be nice to add them.

  4. I know this is older code, but rather than print, can we use the standard form of:

    <% if (newfile) { %> new-file<% } %>
    <% if (binary) { %> binary-file<% } %>
    ...
    
  5. 
      
david
chipx86
  1. 
      
  2. Missing docs here.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (59ac9e4)
Loading...