flake8
passed.
JSHint
passed.
Convert more JS code to ES6.
Review Request #10323 — Created Nov. 16, 2018 and submitted
This covers the various code in the diffviewer directory.
Ran js-tests.
| Description | From | Last Updated |
|---|---|---|
|
Can we put this in alphabetical order? We're also missing docs for these, if you feel like fleshing those out. |
 chipx86
|
|
|
Alphabetical order. If you're up for docs, it'd be nice to add them. |
chipx86
|
|
|
Missing docs here. |
chipx86
|
|
|
"Option Args" |
chipx86
|
|
|
I know this is older code, but rather than print, can we use the standard form of: <% if (newfile) … |
chipx86
|
-
-
reviewboard/static/rb/js/diffviewer/models/diffCommentsHintModel.es6.js (Diff revision 1) Can we put this in alphabetical order?
We're also missing docs for these, if you feel like fleshing those out.
-
reviewboard/static/rb/js/diffviewer/models/paginationModel.es6.js (Diff revision 1) Alphabetical order.
If you're up for docs, it'd be nice to add them.
-
reviewboard/static/rb/js/diffviewer/views/diffComplexityIconView.es6.js (Diff revision 1) "Option Args"
-
reviewboard/static/rb/js/diffviewer/views/diffFileIndexView.es6.js (Diff revision 1) I know this is older code, but rather than
print, can we use the standard form of:<% if (newfile) { %> new-file<% } %> <% if (binary) { %> binary-file<% } %> ...
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/diffviewer/models/paginationModel.es6.js (Diff revisions 1 - 2) Missing docs here.
Commit: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+536 -353)
|
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.