Summary

Update all mutations to use the new signature classes.

Review Request #10303 — Created Nov. 2, 2018 and submitted Dec. 3, 2018, 3:02 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

8efb371...

Reviewers

Groups

django-evolution

People

Description

This switches all the mutations over to using the new signature classes
instead of the old dictionaries, giving us a standard API for working
with signatures and simplifying a lot of code.

For the most part, the changes are fairly straight-forward moves to the
new API. There are a few larger changes that needed to be made, however.

create_field, MockModel, and MockMeta had to be updated to take
some additional arguments that were no longer able to be pulled from
signature dictionaries directly.
SQLMutation now needs to do a bit more work to handle legacy
mutation functions, as it needs to now serialize the signature to a
dictionary that the function can operate on and then replace the
state of the project signature with the results of that function.
ChangeMeta has to do a little more work to check the properties
being changed and manipualting values, since it can't just operate on
raw dictionaries anymore. This actually helps make it more readable
though.

While there's still work that needs to done in some places still to stop
working directly with signature dictionaries, this covers the majority
of those cases. The rest will be handled as part of other changes.

Testing Done

Unit tests pass on all supported versions of Django.

Issues

Description	From	Last Updated
E127 continuation line over-indented for visual indent	reviewbot	Nov. 2, 2018, 1:37 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 2, 2018, 1:37 p.m.
optional?	david	Nov. 14, 2018, 4:54 p.m.
Swap these.	david	Nov. 14, 2018, 4:54 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 2, 2018, 1:37 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 2, 2018, 1:37 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 14, 2018, 4:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 14, 2018, 4:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 14, 2018, 4:55 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Nov. 14, 2018, 4:55 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/mutations.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/mutations.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```

django_evolution/mock_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
optional?
```

django_evolution/mock_models.py (Diff revision 1)

The issue has been resolved. Show all issues

Swap these.

Change Summary:

Fixed docstring issues.

Commit:

46f097c3a4c8a9677d6131892b85e2d3a82dbb78

8efb37167405a4881a7fcbb87b690738ebd212ba

Diff:

Revision 2 (+533 -371)

Show changes

	django_evolution/diff.py
	django_evolution/mock_models.py
	django_evolution/mutations.py
	django_evolution/mutators.py
	django_evolution/signature.py
	django_evolution/management/__init__.py
	django_evolution/tests/base_test_case.py
	django_evolution/tests/test_add_field.py
	11 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

django_evolution/diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/mutations.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```
django_evolution/mutations.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E127 continuation line over-indented for visual indent
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (aebb007)