Summary

Change field type checks to work with subclasses.

Review Request #10298 — Created Nov. 1, 2018 and submitted Nov. 1, 2018, 4:17 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

7a4641f...

Reviewers

Groups

django-evolution

People

Description

There's a large number of legacy if type is ... checks throughout the
codebase, which limits functionality to those specific field types.
While rare, any subclasses of these field types (such as ForeignKey)
would result in broken or inconsistent behavior.

This change updates all these to use issubclass or isinstance
instead of direct type checks.

Testing Done

Unit tests pass on all supported versions of Django.

Issues

Description	From	Last Updated
E231 missing whitespace after ','	reviewbot	Nov. 1, 2018, 3:57 p.m.
W503 line break before binary operator	reviewbot	Nov. 1, 2018, 3:57 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/mock_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
django_evolution/mock_models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W503 line break before binary operator
```