Fix up broken js-tests.
Review Request #10291 — Created Oct. 29, 2018 and submitted — Latest diff uploaded
We had a few JavaScript unit tests which were broken, with two specific
causes:
- For the
ScrollManagerView
, chrome has been doing sub-pixel
scrolling, which broke our tests. I've sprinkled someMath.round()
calls around to fix this. - For the
ReviewReplyEditorModel
, an update to Backbone had broken
some tests which artificially assign an ID in order forisNew()
to
returnfalse
. The newerisNew()
checks theid
attribute
instead of the value in the object.
Ran js-tests.