This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-1.0.x (a9305e7)

Summary

Fix up some more unicode vs. bytes issues.

Review Request #10289 — Created Oct. 29, 2018 and submitted 6 years, 4 months ago

Information

Owner

david*

Repository

RBTools

Branch

release-1.0.x

Bugs

4718, 4754

Depends On

Commit

a9305e7...

Reviewers

Groups

rbtools

People

Description*

This change fixes up some lingering issues related to string types when
running across Python 2 and 3.

Testing Done


Ran unit tests.
Verified rbt diff output when running on Python 3.

Issues

Description	From	Last Updated
Change looks good, but as discussed, let's add some force_* functions for text, strings, bytes in a new rbtools.utils.encoding module, …	chipx86	6 years, 4 months ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Tested here... works for me! Thanks!
```

The issue has been resolved. Show all issues

Change looks good, but as discussed, let's add some force_* functions for text, strings, bytes in a new rbtools.utils.encoding module, so we can start simplifying more code and having common logic.

Commit:

895f458ee27561228690a03e17393fbc9d439aba

a9305e757e85b790a4e76ce55b306fb37c1024a9

Diff:

Revision 2 (+39 -5)

Show changes

	rbtools/commands/diff.py
	rbtools/utils/encoding.py
	rbtools/utils/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Completed
Change Summary:: Pushed to release-1.0.x (a9305e7)