Raise error when no history entries present or a history entry is empty
Review Request #10281 — Created Oct. 25, 2018 and submitted
Previously, the case where
SCMTool.get_commit_history
returnedNone
was not graciously handled inrbt post
leading to an exception. We now
explicitly handle this case and report this to the user.Additionally, we now explicitly handle the case of a commit containing
an empty diff (e.g., if the commit was created with
git commit --allow-empty
), which will not pass validation with Review
Board (as it doesn't allow empty diff uploads).
- Attempted to post an empty history and the appropriate error was
shown. - Attempted to post a history with an empty commit and the
appropriate error was shown.
- Change Summary:
-
Addressed feedback
- Description:
-
~ Previously, the case wehre
SCMTool.get_commit_history
returnedNone
~ Previously, the case where
SCMTool.get_commit_history
returnedNone
was not graciously handled in rbt post
leading to an exception. We nowexplicitly handle this case and report this to the user. Additionally, we now explicitly handle the case of a commit containing
an empty diff (e.g., if the commit was created with git commit --allow-empty
), which will not pass validation with ReviewBoard (as it doesn't allow empty diff uploads). - Commit:
-
113b87475259e97595f78780699c47d60f144981bbaae0fab090899d5341d9a0573f775f6fd67c81
- Diff:
-
Revision 2 (+17 -3)
Checks run (2 succeeded)
- Change Summary:
-
Addressed feedback.
- Commit:
-
bbaae0fab090899d5341d9a0573f775f6fd67c818f8e58d8f66813b6847244b43a719a510f94a522
- Diff:
-
Revision 3 (+17 -3)