Correctly request and return FileDiffs with base FileDiff IDs
Review Request #10245 — Created Oct. 19, 2018 and submitted — Latest diff uploaded
The logic to request a diff fragment with a base FileDiff ID was never
actually implemented. The
RB.DiffReviewablemodel generated a URL with
an invalid query string and, even if it were valid, the
DiffFragmentViewdid not know how to ask for a single FileDiff with a
RB.DiffReviewablemodel now generates a correct URL and the
DiffFragmentViewcan parse this into a call into
the appropriate parameters.
Additionally, the base FileDiff determination in
incorrect: it returned an ancestor that was too old. This has been
corrected to return the least recent FileDiff from after the specified
Ran unit tests.