902: Basic functionality does not work without javascript

itcwm*****@mailina******* (Google Code) (Is this you? Claim this profile.)
Sept. 4, 2009 
Reviewboard basic functionality (reviewing, commenting on, and approving
diffs) should work without javascript.

What steps will reproduce the problem?
1. Disable javascript
2. Log in to reviewboard
3. Select a review request
4. Click "View Diff"

What is the expected output? What do you see instead?
Expected output: the diff to review
Actual output: a list of files that have diffs and a throbber (spinner) graphic

What steps will reproduce the problem?
1. - 3. as above
4. Click "Review"

What is the expected output? What do you see instead?
Expected output: a text box to add review text, and a "Ship It!" checkbox
Actual output: the page does not change

What operating system are you using? What browser?
Windows XP, Mozilla Firefox 2.0.0.20

Please provide any additional information below.
In previous versions of reviewboard, at least viewing of the diff did not
require javascript, and now it does. 

I can't find an "about" page in our reviewboard installation, so I can't
provide specific version numbers.
chipx86
#1 chipx86 
This would take a lot of effort to change, and it's not on the roadmap. Someone who
really wants this would have to champion it and do the work.
  • +Confirmed
  • -Type-Defect
    -Priority-Medium
    +Type-Enhancement
    +Priority-Low
david
#2 david 
I just submitted a change with adds a big ol' warning if you don't have JS enabled,
which will help with the confusing functionality breakage. I don't think we as
project owners are willing to eliminate the JS dependency without someone else doing
it and keeping it working.
  • -Confirmed
    +WontFix