Summary

Fix spying on methods on old-style classes.

Review Request #10199 — Created Oct. 7, 2018 and submitted Oct. 12, 2018, 9:26 a.m.

Information

Owner

chipx86

Repository

kgb

Branch

master

Bugs

Depends On

Commit

d65f131...

Reviewers

Groups

kgb

People

Description

On Python 2.6 and early versions of 2.7, object.__setattr__ can't be
used on old-style classes (those not inheriting from object), which
meant that some spies would succeed on some versions of Python and fail
on others.

We now fall back to simply modifying the dictionary in these cases.

Testing Done

Unit tests pass on all supported versions of Python.

Issues

Description	From	Last Updated
Should we explicitly check for the version here?	brennie	Oct. 8, 2018, 10:02 p.m.

flake8 passed.

JSHint passed.

kgb/spies.py (Diff revision 1)

The issue has been dropped. Show all issues

Should we explicitly check for the version here?

chipx86 Oct. 8, 2018, 10:02 p.m.

No, because it's not clear when this behavior was changed. I'd rather test the result rather than assume anything about versions.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (352ec95)