Clean up comment block and reviewable models
Review Request #10191 — Created Oct. 3, 2018 and submitted — Latest diff uploaded
The
RB.AbstractCommentBlock
andRB.AbstractReviewable
heirarchies
needed some cleaning up. Most of them were lacking documentation about
what their model attributes were. Also theRB.DiffCommentBlock
model
was using ES5 stylemethod: function() {...}
definitions instead of
ES6 stylemethod() {...}
definitions. Finally, the
RB.FileAttachmentReviewable
model was re-defining thecaption
attribute which it inherits from its parent model.All of these issues have been cleaned up. All model attributes are
documented with links back to the parent models for additional
attributes.
Ran JS tests.