Summary

Fix dirty handling for DateTime fields.

Review Request #10145 — Created Sept. 13, 2018 and submitted Sept. 25, 2018, 11:02 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

86eddaf...

Reviewers

Groups

reviewboard

People

Description

The DateTime field selector wasn't properly updating the dirty state of
the editor, which was preventing updates from properly showing the draft
banner. This change fixes the select handling to update things.

Testing Done

Changed a datetime field on a review request and saw the draft banner
appear correctly.

Issues

Description	From	Last Updated
Col: 36 Expected '!==' and instead saw '!='.	reviewbot	Sept. 13, 2018, 5 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 36
 Expected '!==' and instead saw '!='.
```

Commit:

403946979fafe8199446851098aec16d43342792

86eddaf98d3ce670a3039f05b04c55d281412ef3

Diff:

Revision 2 (+5)

Show changes

reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (4e454eb)