flake8
passed.
JSHint
passed.
Disable drag & drop attachment upload when modal dialog is shown
Review Request #10108 — Created July 29, 2018 and updated
The previous behavior could be very annoying when trying to update a
diff using drag & drop. Also, when using the "Add File" dialog the
behavior was confusing.
Chose "Update Diff", dragged file onto browser window
-> drag & drop overlay did not appear
Chose "Add File", dragged file onto browser window
-> drag & drop overlay did not appear
Dragged file onto review request view (Reviews/Diff)
-> drag & drop overlay appeared
| Description | From | Last Updated |
|---|---|---|
|
There's no guarantee that this class name will be used in the future. I think an option that would help … |
 chipx86
|
- Description:
-
~ The behavior can be very annoying when trying to update a diff using
~ drag & drop. Also, when using the "Add File" dialog the behavior is ~ confusing. ~ The previous behavior could be very annoying when trying to update a
~ diff using drag & drop. Also, when using the "Add File" dialog the ~ behavior was confusing.
-
-
There's no guarantee that this class name will be used in the future.
I think an option that would help future-proof would be to introduce signals that
RB.DialogViewsubclasses would automatically emit when showing/hiding to indicate to callers that a dialog is or is not on screen. The file upload area could then listen to this, disabling/re-enabling the upload support as needed.