• 
      

    Snapping file_line to 1, since some tools report general errors as line 0

    Review Request #10093 — Created July 18, 2018 and submitted — Latest diff uploaded

    Information

    ReviewBot
    master
    57dc9c5...

    Reviewers

    Snapping file_line to 1, since some tools report general errors as line 0.

    NOTE: We don't do any any math with num_lines since this is mainly to handle general file errors (maybe there should be a "general comment" for files as well as review requests?).
    NOTE: "Comment on unmodified code" will need to be selected if line 1 wasn't changed.

    Before change -> error displaying diff
    After change -> Comments on line 1 if allowed, otherwise passes.