Refactor routes test into setup/teardown phases
Review Request #10050 — Created June 29, 2018 and submitted — Latest diff uploaded
Since all the routes tests do the same common setup and tear down, they
have been refactored to call a method which returns all the common data
used in the tests (repositories, config instance, etc.) and a way to
tear it down.We now also pass
config.Config
objects by their address since they
contain pointer types (specifically theRepositories
field) to make it
clear that any function receiving them may modify them. Previously it
was possible to modify their pointer fields even if passed by value.
Ran
go fmt ./...
.
Ranmake test
.
Ranmake integration-tests
.