Summary

Fix authentication backends.

Review Request #10045 — Created June 28, 2018 and submitted July 2, 2018, 5:08 p.m.

Information

Owner

easyb

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

b54e827...

Reviewers

Groups

reviewboard

People

Description

BaseAuthBackend.get_user() was removed with commit:
a12a370fd - Modernize the documentation for BaseAuthBackend.

The function is called by Django when the user is authenticated and

therefore required.
Also, the Active Directory backend needed fixing.

Testing Done


Created Docker container form easybe/alpine-reviewboard:wip
Successfully logged in with Active Directory credentials

Issues

Description	From	Last Updated
F821 undefined name 'get_object_or_none'	reviewbot	June 28, 2018, 4:01 p.m.
F821 undefined name 'User'	reviewbot	June 28, 2018, 4:01 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/backends/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'get_object_or_none'
```
reviewboard/accounts/backends/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'User'
```

Change Summary:

fix

Commit:

0f4adf823aa9fd9410f459bba1e0dfa83c6535cc

b54e827d05f461fae7632a05d27a3e46b36074e2

Diff:

Revision 2 (+17 -1)

Show changes

	reviewboard/accounts/backends/ad.py
	reviewboard/accounts/backends/base.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/accounts/backends/base.py (Diff revision 2)

Or should this be implemented in the deriving classes?

Description:: ~
BaseAuthBackend.get_user() was accidentally removed with commit:
~
BaseAuthBackend.get_user() was removed with commit:

a12a370fd - Modernize the documentation for BaseAuthBackend.

Also, the Active Directory backend needed fixing.

Description:: BaseAuthBackend.get_user() was removed with commit:

a12a370fd - Modernize the documentation for BaseAuthBackend.

+
The function is called by Django when the user is authenticated and
+ therefore required.
+

Also, the Active Directory backend needed fixing.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (4a35952)

~		`BaseAuthBackend.get_user()` was accidentally removed with commit:
	~	`BaseAuthBackend.get_user()` was removed with commit:

		`a12a370fd - Modernize the documentation for BaseAuthBackend.`


		Also, the Active Directory backend needed fixing.

		`BaseAuthBackend.get_user()` was removed with commit:

		`a12a370fd - Modernize the documentation for BaseAuthBackend.`


	+	The function is called by Django when the user is authenticated and
	+	therefore required.
	+
		Also, the Active Directory backend needed fixing.