• 
      

    Fix display issues around search filters.

    Review Request #10019 — Created June 13, 2018 and submitted

    Information

    Review Board
    release-3.0.x
    affea31...

    Reviewers

    When search was rewritten for 3.0, search filters were rewritten along
    with it. While they worked under the hood, it broke the display of
    filters.

    When attempting to display the filter options at the top of search
    results, the template was iterating over keys and not items, resulting
    in invisible nonsense being injected into the page. This masked the
    "active filter" check, since filters weren't even being rendered, and
    this was broken due to checking the wrong form field.

    This change fixes the template iteration and the active check, bringing
    back full functionality.

    Tested all filter modes. Verified that filters displayed and the
    active one was always specially displayed.

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (e8d2045)