• 
      

    Always reload token store on config reload; only set when successful

    Review Request #10011 — Created June 11, 2018 and submitted

    Information

    rb-gateway
    master
    0cb4ac6...

    Reviewers

    We now always reload the token store on a config reload to make our
    behaviour identical to that of the htpasswd store. This allows
    administrators to revoke tokens and trigger a reload without restarting
    the server.

    Additionally, we were setting the token store early in
    setConfigUnsafe, which resulted in a partial state update if there
    was an error later. We now make sure to update either everything or
    nothing.

    Testing done:
    Ran go fmt ./....
    Ran go test ./....

    Ran go fmt ./....
    Ran go test ./....

    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (d7165b6)