Ship it status for logged in user.

 






 

 


  Review Request #779
  —
  Created March 24, 2009 and submitted

 


















 

  

   Information

  





 
 

  loki980
 









 
 

  Review Board SVN (deprecated)
 









 
 

  
 









 
 

  909
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Changed the existing "my comments" column to reflect whether or not you indicated "ship it".  If you said "ship it", a different icon is displayed with a checkmark in the center.

I'm not sure how to attach images to this, so I just put it here:
http://i44.tinypic.com/2j18qi9.png

 








  


 
 

  
Not much to test.  Works fine on our install.

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks good. I went ahead and changed this slightly so that instead of doing the "My Ship It" query inside the "My comments" query, we do the "My Ship It" query as a top-level conditional and do the "My comments" query as an elif. This way we reduce the query count by one in the case of your user having Ship It set.

Committed in r1871.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...