timezone string limited to 20 char whereas some timezones are greater than 20

Review Request #4230 — Created June 11, 2013 and submitted

Information

Review Board
1.7.6

Reviewers

timezone is declared 20char long in models.py or django-evolution script whereas some timezones are greater
America/Argentina/Buenos_Aires is the longest => 30 chars

this issue can also be seen in current master branch
$ ./reviewboard/manage.py evolve --hint --execute
$ mysql -u reviewboard -p -D reviewboard -e "desc accounts_profile;" |grep timezone
timezone	varchar(30)	YES		NULL	
Description From Last Updated

Col: 62 W291 trailing whitespace

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/accounts/evolutions/__init__.py
        reviewboard/accounts/evolutions/timezone_length_30.py
        reviewboard/accounts/models.py
      Ignored Files:
    
    
  2. Col: 62
     W291 trailing whitespace
    
  3. 
      
chipx86
  1. Ship It!
  2. 
      
DE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (ee9b33d)
Loading...