Render new RRs, Reviews and Comments as markdown.

Review Request #3892 — Created Feb. 19, 2013 and discarded

Information

Review Board
master

Reviewers

What has been done, 
- Add rich_text db evolution script. 
  - All old ReviewRequests, Reviews and Comments are marked as `rich_text = False`
  - All later ReviewRequests, Reviews and Comments will be marked as `rich_text = True`
- Enable markdown rendering with code highlight for all pre-text blocks
  - Use `marked` js lib render text
  - Use `google code prettify` for syntax highlighting
  - Rendered text are inserted along the page loading process using `document.write()`
- Use single template file to generate text blocks
- Always place text inside <pre> tag
- Adjust the css style for markdown text
Execute `./reviewboard/manage.py evolve --execute` on RB 1.7.6 database. 
- All reviews and comments are marked as `rich_text = False`

Then post a new review. 
- The new review is marked as `rich_text = True`
- The new review is rendered as Markdown with `.rich-text` class attribute
- The old reviews stays as they used to be

Description From Last Updated

Col: 21 E128 continuation line under-indented for visual indent

reviewbotreviewbot

So, Django Evolution has some design problems that we're trying to work around, and one of the necessary workarounds is …

chipx86chipx86

The jquery-ui bit is because Djblets owns a copy of jquery-ui and we want to make sure that both Djblets …

chipx86chipx86

Col: 7 E702 multiple statements on one line (semicolon)

reviewbotreviewbot

Can this not be combined with rich_text.py?

mike_conleymike_conley

indent this one more space

mike_conleymike_conley

typo: nad -> and

mike_conleymike_conley

If this isn't needed, please remove it.

mike_conleymike_conley

What node is this trying to remove?

mike_conleymike_conley
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/evolutions/rich_text.py
        reviewboard/reviews/models.py
      Ignored Files:
        reviewboard/templates/reviews/review_detail.html
    
    
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Col: 21
     E128 continuation line under-indented for visual indent
    
  3. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/evolutions/rich_text.py
        reviewboard/reviews/models.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/prettify.css
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/templates/base.html
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/templates/js/richtext.html
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
mike_conley
  1. So far this looks really good, Greg! Keep it up!
  2. 
      
chipx86
  1. 
      
  2. reviewboard/reviews/evolutions/rich_text.py (Diff revision 2)
     
     
     
    So, Django Evolution has some design problems that we're trying to work around, and one of the necessary workarounds is that we don't introduce evolutions for tables that haven't been around since the first release. FileAttachmentComment is newer than that.
    
    I'm hoping to find a way to change that so that it's not a problem, but for now, I want to make sure we're more bullet-proof.
    
    Can you make a second evolution that does just this particular AddField? Make sure to test that it works against a database made prior to these evolutions.
  3. reviewboard/templates/base.html (Diff revision 2)
     
     
    The jquery-ui bit is because Djblets owns a copy of jquery-ui and we want to make sure that both Djblets and Review Board share the same definitions, which Review Board can override.
    
    In your case, there should not be a separate file. Instead, all the scripts we need for this feature should be defined as a "markdown" Pipeline JavaScript bundle in settings.py (PIPELINE_JS dictionary). Then you should just use {% compressed_js "markdown" %} on it.
    
    Same thing for CSS.
  4. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/models.py
        reviewboard/settings.py
        reviewboard/reviews/evolutions/rich_text.py
        reviewboard/reviews/evolutions/rich_text_file_attach_comment.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
        reviewboard/reviews/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/evolutions/rich_text_file_attach_comment.py
        reviewboard/reviews/evolutions/rich_text.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
        reviewboard/reviews/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/evolutions/rich_text_file_attach_comment.py
        reviewboard/reviews/evolutions/rich_text.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/templates/reviews/review_rich_text_markdown.html
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. Col: 7
     E702 multiple statements on one line (semicolon)
    
  3. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
        reviewboard/reviews/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/evolutions/rich_text_file_attach_comment.py
        reviewboard/reviews/evolutions/rich_text.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/rb/js/utils/textUtils.js
        reviewboard/templates/reviews/review_text_block.html
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
mike_conley
  1. Greg, is this ready to come out of WIP yet?
    1. Here we go. Tweaked all the styles. That was the only thing missing. 
  2. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
        reviewboard/reviews/models.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/evolutions/rich_text_file_attach_comment.py
        reviewboard/reviews/evolutions/rich_text.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/rb/css/richtext.css
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/rb/js/utils/textUtils.js
        reviewboard/templates/reviews/review_text_block.html
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
mike_conley
  1. Greg:
    
    This is a really sexy, exciting change! I just played with this patch, and I really dug it. :)
    
    Just a few notes below,
    
    -Mike
  2. Can this not be combined with rich_text.py?
    1. Chip mentioned, combined in rich_text.py will cause some problem with Django Evolution. Please refer to http://reviews.reviewboard.org/r/3892/#comment9237 
    2. Oh yeah, I fixed the bug! It can be one file now.
    3. Here we go, reverted that commit. Love Git. 
  3. reviewboard/static/rb/js/reviews.js (Diff revision 7)
     
     
    indent this one more space
  4. typo: nad -> and
  5. If this isn't needed, please remove it.
  6. What node is this trying to remove?
    1. The content of `#{{dom_id}}-markdown` is used as input for markdown rendering. This block is hidden, but not necessary to be removed. 
      
      We may want to keep this, and use as the input of text editor. (For now, inline text editor doesn't keep any markdown format tags.)
    2. I see your point. I forgot to change the ID to `-raw`. But I guess I will get rid of this line. 
  7. 
      
GR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/settings.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/evolutions/rich_text.py
        reviewboard/reviews/models.py
      Ignored Files:
        reviewboard/static/lib/js/google-code-prettify/lang-proto.js
        reviewboard/static/rb/css/richtext.css
        reviewboard/static/lib/js/google-code-prettify/lang-lua.js
        reviewboard/static/lib/js/google-code-prettify/lang-ml.js
        reviewboard/static/lib/js/google-code-prettify/lang-yaml.js
        reviewboard/static/lib/css/prettify.css
        reviewboard/static/lib/js/google-code-prettify/lang-n.js
        reviewboard/static/lib/js/google-code-prettify/lang-tex.js
        reviewboard/static/lib/js/google-code-prettify/lang-lisp.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/lib/js/google-code-prettify/lang-vhdl.js
        reviewboard/static/lib/js/google-code-prettify/lang-dart.js
        reviewboard/templates/reviews/review_reply.html
        reviewboard/static/lib/js/marked.js
        reviewboard/static/lib/js/google-code-prettify/lang-r.js
        reviewboard/static/lib/js/google-code-prettify/lang-apollo.js
        reviewboard/static/lib/js/google-code-prettify/lang-vb.js
        reviewboard/static/lib/js/google-code-prettify/lang-tcl.js
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/lib/js/google-code-prettify/run_prettify.js
        reviewboard/static/lib/js/google-code-prettify/lang-xq.js
        reviewboard/static/lib/js/google-code-prettify/lang-scala.js
        reviewboard/static/lib/js/google-code-prettify/lang-clj.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/static/lib/js/google-code-prettify/lang-sql.js
        reviewboard/static/lib/js/google-code-prettify/lang-erlang.js
        reviewboard/static/lib/js/google-code-prettify/prettify.js
        reviewboard/static/rb/js/utils/textUtils.js
        reviewboard/templates/reviews/review_text_block.html
        reviewboard/static/lib/js/google-code-prettify/lang-wiki.js
        reviewboard/static/lib/js/google-code-prettify/lang-css.js
        reviewboard/static/lib/js/google-code-prettify/lang-rd.js
        reviewboard/static/lib/js/google-code-prettify/lang-go.js
        reviewboard/static/lib/js/google-code-prettify/lang-basic.js
        reviewboard/static/lib/js/google-code-prettify/lang-mumps.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/lib/js/google-code-prettify/lang-hs.js
        reviewboard/static/lib/js/google-code-prettify/lang-llvm.js
        reviewboard/static/lib/js/google-code-prettify/lang-pascal.js
    
    
  2. 
      
mike_conley
  1. This is awesome! I can't find anything wrong with it - it's got my ship-it. Great job!
    1. Thanks! 
      
      Well, one thing I have to mention is the inline editor. Triggering inline editor on a "markdowned" text block will loss all markdown format tags. That is a really bad UX. So might have to disable the rendering for the text block with inline editor for now (They are `description`, `testing-done` and `comments`). They can be re-enabled after the editor patch. 
      
      I'm digging into the inline editor now. If I see any possible easy work around, I will update it. 
  2. 
      
david
  1. Just like to mention that we've been working on fixing up the issues here (especially with the inline editor) and this will go in soon. I've got a new change at https://reviews.reviewboard.org/r/4506/ that obsoletes this one.
  2. 
      
GR
Review request changed

Status: Discarded

Loading...