Summary

Provide a Admin UI setting to change Log Levels

Review Request #3851 — Created Feb. 7, 2013 and submitted Feb. 7, 2013, 6:42 p.m.

Information

Owner

rajasaur

Repository

Djblets

Branch

Bugs

1859

Depends On

Reviewers

Groups

djblets

People

Description

Allow Logging level to be setup in Admin UI
    
Currently, the logging level can only be setup only in settings_local.py which makes it difficult to change the value. Provide a dropdown in the Admin->Logging Screens that shows the various logging levels.
    
Added default value for logging_level in siteconfig.py as well as mapped the field shown in the UI to the internal variable in siteconfiguration tables.

This patch goes along with the Reviewboard change at #3852 (http://reviews.reviewboard.org/r/3852/)

Testing Done

Verified in fresh setup (devserver) where it defaults to the DEBUG level.  Since this only gets stored in siteconfig_siteconfiguration table, shouldn't need any migration changes. Changed the level manually in the UI and verified that DEBUG messages dont appear anymore.

Also the Filter in Admin->Server Log shows only the LogLevel selected and anything above it. For e.g. if the logging is set to ERROR, the filters in Server Log only show Error, Critical and ALL.

Issues

Description	From	Last Updated
Col: 21 E241 multiple spaces after '	reviewbot	Feb. 7, 2013, 10:55 a.m.
Col: 21 E241 multiple spaces after '	reviewbot	Feb. 7, 2013, 10:56 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    djblets/log/siteconfig.py
  Ignored Files:

djblets/log/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 E241 multiple spaces after '
```
1. RA
  
  rajasaur Feb. 7, 2013, 10:56 a.m.
  Maintain consistency with the rest of the lines in this block
djblets/log/siteconfig.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 21
 E241 multiple spaces after '
```
1. RA
  
  rajasaur Feb. 7, 2013, 10:56 a.m.
  same as above

Change Summary:

Updated to include the associated reviewboard patch

Description:

		Allow Logging level to be setup in Admin UI

		Currently, the logging level can only be setup only in settings_local.py which makes it difficult to change the value. Provide a dropdown in the Admin->Logging Screens that shows the various logging levels.

		Added default value for logging_level in siteconfig.py as well as mapped the field shown in the UI to the internal variable in siteconfiguration tables.
	+
	+	This patch goes along with the Reviewboard change at #3852 (http://reviews.reviewboard.org/r/3852/)

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f89aec5). Thanks!

djblets/log/siteconfig.py (Diff revision 1)

djblets/log/siteconfig.py (Diff revision 1)