Fixed the SMTP whitespace big. SMTP address with whitespaces are now stripped properly.

Review Request #3759 — Created Jan. 18, 2013 and submitted

Information

Review Board
master

Reviewers

Fixed the SMTP whitespace big. SMTP address with whitespaces are now stripped properly.
Produced the bug with an smtp server "smtp.gmail.com     " and triggered an email event (registration for new user). Log produced an error: "Unknown host". Added the changes on the diff and tried again, the email is sent and the value that is saved is stripped of the redudant spaces.
Description From Last Updated

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 51 W291 trailing whitespace

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/admin/forms.py
      Ignored Files:
    
    
  2. reviewboard/admin/forms.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  3. reviewboard/admin/forms.py (Diff revision 1)
     
     
    Col: 51
     W291 trailing whitespace
    
  4. 
      
AY
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/admin/forms.py
      Ignored Files:
    
    
  2. 
      
david
  1. What testing did you do? Can you fill out the "Testing done" field with that?
  2. 
      
AY
david
  1. Ship It!
  2. 
      
AY
AY
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (e6e5d07). Thanks!
Loading...