Add support for github enterprise

Review Request #3425 — Created Oct. 17, 2012 and discarded

Information

Review Board
master

Reviewers

Add support for github enterprise as a hosted repository. This now uses the github v3 api for access. Some rewrite of the scmtools/forms.py was needed in order to pass down the repository extra information, such as the github enterprise hostname, for service authentication.

Note: this is similar functionality to what Edmundo submitted (http://reviews.reviewboard.org/r/3376/) This should be a more minimal change and all the repo settings are stored in the model (rather than settings_local.py).
Added unit tests that passed. Configured public and enterprise repositories.
Description From Last Updated

Sai r?i pa

RO ronaldoit
chipx86
  1. Does GitHub Enterprise only have organizations, or are there per-user accounts as well? What about a concept of public/private repositories?
    1. Yes, there can be multiple organizations and per-user public/private repositories. However, the API URL would still be supported via the enterprise diff to access the github api. In other words, for a per-user repo you would add another Review Board repository with the same repo host name, the "Organization name" being the user and then specifying the repo name. The main thing this diff does is use the enterprise host name and a slightly different API URL which is specific to the github enterprise product.
    2. For consistency and usability, would it not make sense to have Enterprise equivalents of each of the existing types? Public, Private, Public Org, Private Org?
      
      I'm thinking a GitHub Enterprise hosting service (rather than plans) makes more sense. The GitHubEnterprise HostingService class could largely subclass the GitHub class and change the API URLs.
  2. 
      
RO
  1. 
      
  2. reviewboard/hostingsvcs/tests.py (Diff revision 1)
     
     
    Show all issues
    Sai r?i pa
    1. Please do not use this for testing. This is a production server.
  3. 
      
MA
Review request changed

Status: Discarded

Loading...