-
-
reviewboard/reviews/models.py (Diff revision 1) I *think* you can just do: display_verb = property(get_verb_display) Might be nice to just add a simple comment saying that get_verb_display is provided automatically .by the verb field. I was confused at first as to where this came from.
-
reviewboard/static/rb/css/action-feed.less (Diff revision 1) Ideally, should be alphabetized. We're not always good at this, but for new code, yeah :)
-
reviewboard/static/rb/js/action-feed.js (Diff revision 1) Really, this should be: changeitem .append(' changed from ') .append($('<i/>').text(oldValue) ... ...; -
-
-
reviewboard/static/rb/js/action-feed.js (Diff revision 1) I think these could just go inline when building the div below.
-
reviewboard/static/rb/js/action-feed.js (Diff revision 1) This should be more clear as to what we're loading. Should mention actions.
-
-
-
-
-
reviewboard/webapi/resources.py (Diff revision 1) Can we just get this from the review request we link to? I don't know that exposing this is right.
-
reviewboard/webapi/resources.py (Diff revision 1) How necessary is this? It'd be nice to use the linked resource instead.
-
-
-
reviewboard/webapi/resources.py (Diff revision 1) Rather than basing it on a last ID like this, it might be better to allow searching by a time range. Preferably, we shouldn't be passing around IDs much.
'Load more' functionality for the action feed
Review Request #3260 — Created Aug. 3, 2012 and discarded
This patch is built on top of the one in r/3151/ Changes include: * generating the action feed by getting the action list via ajax. * brand new "Load more" button
| Description | From | Last Updated |
|---|---|---|
|
I *think* you can just do: display_verb = property(get_verb_display) Might be nice to just add a simple comment saying that … |
 chipx86
|
|
|
Ideally, should be alphabetized. We're not always good at this, but for new code, yeah :) |
chipx86
|
|
|
Really, this should be: changeitem .append(' changed from ') .append($('').text(oldValue) ... ...; |
chipx86
|
|
|
One per line. |
chipx86
|
|
|
The ) should be on the previous line. |
chipx86
|
|
|
I think these could just go inline when building the div below. |
chipx86
|
|
|
This should be more clear as to what we're loading. Should mention actions. |
chipx86
|
|
|
Space before { |
chipx86
|
|
|
Remove these blank lines. |
chipx86
|
|
|
Probably want to remove that. |
chipx86
|
|
|
. No end tag. |
chipx86
|
|
|
Can we just get this from the review request we link to? I don't know that exposing this is right. |
chipx86
|
|
|
How necessary is this? It'd be nice to use the linked resource instead. |
chipx86
|
|
|
"change description" |
chipx86
|
|
|
"Human-readable" |
chipx86
|
|
|
Rather than basing it on a last ID like this, it might be better to allow searching by a time … |
chipx86
|
