Summary

Added password reentry and verification in rb-site install

Review Request #2818 — Created Jan. 22, 2012 and submitted Jan. 31, 2012, 6:25 a.m.

Information

Owner

weilul

Repository

Review Board

Branch

Bugs

1631

Depends On

Reviewers

Groups

reviewboard

People

Description

There are two passwords prompts when installing a new site. One for the database, one for the admin user.

For the database: created variable "reenter_db_pass" in class "site", and added prompt input "Re=enter Database Password" to the screen; for the admin user: "reenter_admin_password", and "Re-enter Password".

Generally, created function "compare_var" in class "GtkUI" to check if the password matches its reentry; added the return value of the function to the variable "page[validators]".

In installation, the "next" button is disabled until the password matches its reentry.

Testing Done

Successfully tested on my ubuntu(virtual box)

Screenshots

Issues

Description	From	Last Updated
A slightly better option is this: if not save_var.startswith('reenter'):	david	Jan. 30, 2012, 10:11 a.m.
This function name isn't very good. How about "confirm_reentry"?	david	Jan. 30, 2012, 10:11 a.m.
Can you change this to "Confirm Database Password"?	david	Jan. 30, 2012, 10:11 a.m.
"Confirm Password"	david	Jan. 30, 2012, 10:11 a.m.
Don't add this line.	david	Jan. 30, 2012, 10:11 a.m.

reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
A slightly better option is this:
if not save_var.startswith('reenter'):
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This function name isn't very good. How about "confirm_reentry"?
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you change this to "Confirm Database Password"?
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"Confirm Password"
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Don't add this line.
```

Change Summary:

Changed the code based on the suggestions from David Trowbridge. Successfully tested on my local dev server.

Diff:

Revision 2 (+13)

Show changes

reviewboard/cmdline/rbsite.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (7b42518). Thanks!