1730: post-review with mercurial fails with obscure error if there are no outgoing changesets

ball****@aica***** (Google Code) (Is this you? Claim this profile.)
Oct. 9, 2011
What version are you running?

RB 1.5beta2, RBTools 0.2.1alpha0

What's the URL of the page containing the problem?

post-review output

What steps will reproduce the problem?
1.Setup RB with a mercurial repository
2. Make a local clone
3.Invoke 'post-review -d' (there are no outgoing changes)

What is the expected output? What do you see instead?

Expected: reasonable error or information message.

Instead I get:

plato:testservice ballarin$ post-review -d
>>> svn info
>>> hg showconfig
>>> hg root
>>> hg svn info
>>> Using candidate path 'default': 'ssh://...//.../testservice'
>>> repository info: Path: ssh://...//.../testservice, Base path: , Supports changesets: False
>>> hg branch
>>> hg -q outgoing --template b:{branches}
r:{rev}

 default
Failed to execute command: ['hg', '-q', 'outgoing', '--template', 'b:{branches}\nr:{rev}\n\n', 'default']


What operating system are you using? What browser?

RB: CentOS 5.5, Local: Mac OS X

Please provide any additional information below.

Behaves normally if there are outgoing changes.
#1 ma**@catley******* (Google Code) (Is this you? Claim this profile.)
I have noticed this too, and have written a fix for our internal version of rbtools. Is there any appetite for getting this into the main repository?
david
#2 david
Yes please.
#3 ma**@catley******* (Google Code) (Is this you? Claim this profile.)
See http://reviews.reviewboard.org/r/2632.

Also I have a bug/review out that fixes the calculation of diffs if a merge has occurred with post-review and mercurial. See:
http://code.google.com/p/reviewboard/issues/detail?id=2311
http://reviews.reviewboard.org/r/2628/
#4 ma**@catley******* (Google Code) (Is this you? Claim this profile.)
My fixes have been applied to master (052dfeb), and I have tested them out of master. All still works as expected.
david
#5 david
Thanks!
  • +Fixed