Summary

Bare repositories and git-rev-parse support in post-review.

Review Request #2233 — Created April 3, 2011 and submitted

Information

Owner

jan.koprowski

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Review can be done also inside bare repository. Also --revision-range="" can be any git-revision from git-rev-parse manual: http://www.kernel.org/pub/software/scm/git/docs/git-rev-parse.html.

Testing Done

Tested under Linux on Git 1.7.4.1
On normal clone - made by "git clone"
On bare repository - made by "git init --bare"
On bare clone - made by "git clone --bare"

Don't rush with this patch please :)
I'm trying to make this part even more general and I will try to made them even more flexible then this.
I will get You know when it be done.

Change Summary:

Update diff.
Change Summary and Description.

Summary:

-	post-review --parent review request from inside of git-bare repository
+	Bare repositories and git-rev-parse support in post-review.

Description:

~		post-review command line can request review with --parent option from inside of bare-repository which allow use post-review inside pre-receive git's hook.
	~	Review can be done also inside bare repository. Also --revision-range="" can be any git-revision from git-rev-parse manual: http://www.kernel.org/pub/software/scm/git/docs/git-rev-parse.html.

Diff:

Revision 2 (+22 -8)

Show changes

rbtools/postreview.py

Testing Done:

~		Tested under Linux on Git 1.7.4.1
	~	Tested under Linux on Git 1.7.4.1
	+	On normal clone - made by "git clone"
	+	On bare repository - made by "git init --bare"
	+	On bare clone - made by "git clone --bare"

Is there chance to put it in rbtools released with ReviewBoard 1.6?

chipx86 May 23, 2011, 5:52 a.m.

Definitely. You originally said not to rush so I assumed it wasn't done :) But then I missed the update after that.

Ship it!

```
Ship It!
```

Ship it!

```
Thanks! Committed to master (d7ec4f4)
```