Summary

adding clickability to summary td elements

Review Request #1468 — Created March 9, 2010 and submitted

Information

Owner

dbuch-agi

Repository

Djblets

Branch

Bugs

1022

Depends On

Reviewers

Groups

djblets, reviewboard

People

chipx86, david, mcrute

Description

This patch seeks to provide the behavior described by chipx86 in comment #4 on the issue detail page.

Testing Done

Lots of browser testing in Chrome.

Verified with Chrome debugger that click event is only attached to target "td.summary" elements.

djblets/media/js/datagrid.js (Diff revision 1)

First line in a multi-line comment shouldn't have any text.

djblets/media/js/datagrid.js (Diff revision 1)

These should be combined into one line. See the editButton.click above.

djblets/media/js/datagrid.js (Diff revision 1)
```
Space between "if" and "("
```

Change Summary:

changes per chipx86 feedback

Diff:

Revision 2 (+17)

Show changes

djblets/media/js/datagrid.js

Testing Done:

		Lots of browser testing in Chrome.
	+
	+	Verified with Chrome debugger that click event is only attached to target "td.summary" elements.

```
BUMP
```

Ship it!

Looks good. Pushed to djblets master as aa6f3a5.

Actually, I know that this was committed, but after looking at it again I realized the change was made in the wrong place. Djblets should not know anything about Summary cells. This is a Review Board-specific thing. This logic really should exist in Review Board and not in Djblets.

david July 3, 2011, 10:49 a.m.

I actually don't think that this is a bad thing to have in djblets. It's not unusual for a datagrid to have a special column for the summary, and this is a pretty generic solution.